Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cesium.com branch for real I swear #11664

Merged
merged 1 commit into from
Dec 2, 2023
Merged

Fix cesium.com branch for real I swear #11664

merged 1 commit into from
Dec 2, 2023

Conversation

mramato
Copy link
Contributor

@mramato mramato commented Dec 2, 2023

We don't actually build the zip in cesium.com deploy, we fetch it from GH releases. That's the root cause of why unzipping was failing.

@mramato
Fix cesium.com branch for real I swear
ce5da75 
We don't actually build the zip in cesium.com deploy,
we fetch it from GH releases. That's the root cause
of why unzipping was failing.
@mramato mramato requested a review from jjhembd December 2, 2023 00:09
jjhembd
jjhembd approved these changes Dec 2, 2023
View reviewed changes
Copy link
Contributor

@jjhembd jjhembd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified the curl commands on my machine. Also this seemed to work on our last deployment, so I think it's good to go.
Thanks again @mramato!

@jjhembd jjhembd merged commit c0a735d into main Dec 2, 2023
5 checks passed
@jjhembd jjhembd deleted the fix-deploy-again branch December 2, 2023 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjhembd jjhembd jjhembd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mramato @jjhembd