Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement EIP-7691 increase blob throughput #7309
base: devnet-5
Are you sure you want to change the base?
feat: implement EIP-7691 increase blob throughput #7309
Changes from 16 commits
13d6448
a8d9f73
e6984f4
6b48588
1722971
f031dc3
a8f34b8
d3361b4
ebc2aae
7a51d37
13ad885
2c68274
c22f78b
aa8a218
41be261
1c2b5ed
a267c34
e813294
744c0be
760fbb8
8a49542
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whats different in v2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Max size of the param in V1 is
MAX_REQUEST_BLOB_SIDECARS
(768) , V2 isMAX_REQUEST_BLOB_SIDECARS_ELECTRA
(1152)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need this for v1/v2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, request type for BlobSidecarsByRootV2 has changed. But
ReqRespMethod
does not communicate version info, so we can only pass in fork info to determine the correct type.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't type be the same just that v2 will have context bytes/fork type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
V2 accepts higher number of blob requests so the ssz container is different.