Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix beacon proposer cache unit tests #7335

Merged
merged 2 commits into from
Jan 7, 2025
Merged

chore: fix beacon proposer cache unit tests #7335

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9f2eeb
chore: fix beacon proposer cache unit tests
nflaig Jan 7, 2025
abce9d1
Assign values to named constants
nflaig Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...de/test/unit/chain/beaconProposerCache.ts → ...st/unit/chain/beaconProposerCache.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ describe("BeaconProposerCache", () => {
});

it("get default", () => {
expect(cache.get(32)).toBe("0xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa");
expect(cache.getOrDefault(32)).toBe("0xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we you refactoring this code, will suggest to not use such magic numbers. Instead assign these values to some named constants and use in tests. Will make code more readable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did a bit of refactoring

});

it("get what has been set", () => {
Expand All @@ -29,7 +29,7 @@ describe("BeaconProposerCache", () => {
cache.prune(4);

// Default for what has been pruned
expect(cache.get(23)).toBe("0xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa");
expect(cache.getOrDefault(23)).toBe("0xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa");

// Original for what hasn't been pruned
expect(cache.get(43)).toBe("0xcccccccccccccccccccccccccccccccccccccccc");
Expand Down
Loading