Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EAGLE-3552][EAGLE-3567] - Add inference params and multimodal-embedder model #201

Merged
merged 7 commits into from
Oct 25, 2023
Merged

[EAGLE-3552][EAGLE-3567] - Add inference params and multimodal-embedder model #201

merged 7 commits into from
Oct 25, 2023

Conversation

phatvo9
Copy link
Contributor

@phatvo9 phatvo9 commented Oct 19, 2023 •
edited by jira bot
Loading

EAGLE-3552 - Add inference parameters:

  • Modify model.py and inference.py to receives them
  • Generate JSON file for uploading
  • Test with inference parameters
  • update doc

EAGLE-3552 - add multimodal-embedder model type

HarmitMinhas96
HarmitMinhas96 reviewed Oct 19, 2023
View reviewed changes
Copy link
Contributor

@HarmitMinhas96 HarmitMinhas96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you possibly split the multi-modal embedder into it's own smaller PR?

clarifai/models/model_serving/docs/inference_parameters.md Outdated Show resolved Hide resolved
clarifai/models/model_serving/models/model_types.py Outdated Show resolved Hide resolved
clarifai/models/model_serving/model_config/inference_parameter.py Show resolved Hide resolved
clarifai/models/model_serving/model_config/inference_parameter.py Outdated Show resolved Hide resolved
clarifai/models/model_serving/docs/inference_parameters.md Outdated Show resolved Hide resolved
clarifai/models/model_serving/docs/inference_parameters.md Outdated Show resolved Hide resolved
@phatvo9 phatvo9 merged commit 8900ee2 into master Oct 25, 2023
@phatvo9 phatvo9 deleted the EAGLE-3552 branch October 25, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemoveon2 wemoveon2 wemoveon2 left review comments

@HarmitMinhas96 HarmitMinhas96 HarmitMinhas96 approved these changes

@ackizilkale ackizilkale Awaiting requested review from ackizilkale

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@phatvo9 @HarmitMinhas96 @wemoveon2 @ackizilkale