Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEVX-289]: Fix passing BaseURL info #210

Merged
merged 1 commit into from
Nov 15, 2023
Merged

[DEVX-289]: Fix passing BaseURL info #210

merged 1 commit into from
Nov 15, 2023

Conversation

sainivedh
Copy link
Contributor

@sainivedh sainivedh commented Nov 14, 2023 •
edited
Loading

What

  • Fix BaseURL info not passing down to other resources
  • Now users can be able to do
user = User(user_id = user_id, base_url = base_url)
app = user.app(app_id = app_id)
model = app.model(model_id = model_id,model_version_id = version_id)

@sainivedh sainivedh marked this pull request as ready for review November 14, 2023 10:09
sanjaychelliah
sanjaychelliah approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@sanjaychelliah sanjaychelliah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sainivedh sainivedh merged commit 466e321 into master Nov 15, 2023
4 checks passed
@sainivedh sainivedh deleted the DEVX-289-fix-baseurl branch November 15, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanjaychelliah sanjaychelliah sanjaychelliah approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sainivedh @sanjaychelliah