Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cargoculted predecessor_mapgen on incomplete campsite roof #78861

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Remove cargoculted predecessor_mapgen on incomplete campsite roof #78861

merged 1 commit into from
Jan 3, 2025

Conversation

Procyonae
Copy link
Contributor

@Procyonae Procyonae commented Dec 30, 2024 •
edited
Loading

Summary

None

Purpose of change

Fixes #78816

Describe the solution

Describe alternatives you've considered

Testing

Additional context

Removed a couple of other cargo culted fields while I were checking nothing else was wrong

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 30, 2024
@Maleclypse Maleclypse merged commit 303f60d into CleverRaven:master Jan 3, 2025
25 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

campsite_cabin_incomplete_roof probably shouldn't have predecessor_mapgen set to "forest"
2 participants
@Procyonae @Maleclypse