Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update climacommon to 2024_12_16 #3369

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Conversation

Sbozzolo
Copy link
Member

@Sbozzolo Sbozzolo commented Oct 8, 2024

🤖 Beep boop. I am GabrieleBOT. 🤖

I received an update so that I can inform you directly of the changes (but feel free to check the release notes).

The most recent version of climacommon uses the newly released Julia 1.11.2.

@Sbozzolo Sbozzolo force-pushed the gb/update-climacommon-to-2024_10_09 branch 3 times, most recently from 5bcb62f to 9446cc7 Compare October 17, 2024 23:02
@Sbozzolo Sbozzolo changed the title Update climacommon to 2024_10_09 Update climacommon to 2024_12_16 Jan 6, 2025
@Sbozzolo Sbozzolo force-pushed the gb/update-climacommon-to-2024_10_09 branch 2 times, most recently from 7f53669 to 078c0b8 Compare January 8, 2025 15:27
@charleskawczynski
Copy link
Member

Among the GHA tests, it looks like the windows job gets the farthest, reaching (but not completing) test_init_with_file.jl. It could be that that is an artifact download issue (maybe even on windows?). Hm, but macOS got that far on the one before that 🤔. Ah, we have timeout-minutes: 30 for CI, I'm fine bumping that to 1 hr. It's probably just taking longer due to slower compilation time.

@charleskawczynski
Copy link
Member

On buildkite, it looks like some jobs are getting precompiled twice, ah this is likely due to using a fixed old version of atmos. Developing atmos in the perf env should fix this, I think.

@charleskawczynski
Copy link
Member

We can increase the ref counter to fix the reproducibility tests, could someone review the physics changes?

@charleskawczynski
Copy link
Member

Finally, the MPI job looks like it may be running out of memory, could we increase the mem request for test restart MPI?

Copy link
Member

@charleskawczynski charleskawczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall updating to julia 1.11 is fine with me, but it looks like we need to address some things that need fixed.

@Sbozzolo Sbozzolo force-pushed the gb/update-climacommon-to-2024_10_09 branch 4 times, most recently from f12ee9e to fa8cdd8 Compare January 9, 2025 16:26
@Sbozzolo
Copy link
Member Author

Sbozzolo commented Jan 9, 2025

I am finding that ClimaCore 0.14.12 is fine with Julia 1.10, but we need 0.14.19 for Julia 1.11 (https://github.com/CliMA/ClimaAtmos.jl/actions/runs/12694181365/job/35383420600).

Unfortunately, I don't see any easy way to specify this constraint, so maybe the safest is just bumping the minimum to 0.14.19

@Sbozzolo Sbozzolo force-pushed the gb/update-climacommon-to-2024_10_09 branch from fa8cdd8 to b661730 Compare January 9, 2025 16:49
@charleskawczynski
Copy link
Member

I am finding that ClimaCore 0.14.12 is fine with Julia 1.10, but we need 0.14.19 for Julia 1.11 (https://github.com/CliMA/ClimaAtmos.jl/actions/runs/12694181365/job/35383420600).

Unfortunately, I don't see any easy way to specify this constraint, so maybe the safest is just bumping the minimum to 0.14.19

That makes sense. We kind of got bit by JuliaLang/julia#56295. The main branch is fine, but the high-level dispatch that effectively fixed this issue must have been merged in 0.14.19.

I don't know what we could have done to prevent this, unfortunately.

@Sbozzolo Sbozzolo force-pushed the gb/update-climacommon-to-2024_10_09 branch 3 times, most recently from 0c9c45f to e678e1e Compare January 14, 2025 15:45
@Sbozzolo Sbozzolo added this pull request to the merge queue Jan 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 15, 2025
@Sbozzolo Sbozzolo added this pull request to the merge queue Jan 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jan 15, 2025
@Sbozzolo Sbozzolo force-pushed the gb/update-climacommon-to-2024_10_09 branch from e678e1e to 550cdf3 Compare January 16, 2025 17:40
@Sbozzolo Sbozzolo enabled auto-merge January 16, 2025 17:40
@Sbozzolo Sbozzolo added this pull request to the merge queue Jan 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jan 16, 2025
@Sbozzolo Sbozzolo force-pushed the gb/update-climacommon-to-2024_10_09 branch from 550cdf3 to 2b9c1ab Compare January 16, 2025 20:32
@Sbozzolo Sbozzolo enabled auto-merge January 16, 2025 20:33
@Sbozzolo Sbozzolo added this pull request to the merge queue Jan 16, 2025
Merged via the queue into main with commit ab37d6d Jan 17, 2025
21 of 22 checks passed
@Sbozzolo Sbozzolo deleted the gb/update-climacommon-to-2024_10_09 branch January 17, 2025 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants