Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try using purely vertical spaces for column configurations #3398

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

charleskawczynski
Copy link
Member

While looking at calibrations, I realized that we seem to always generate VIJFH datalayouts, even for column cases. Our CPU and GPU code paths for each datalayout is split so that we can optimize kernels specifically for those datalayouts. So, we should probably allow these spaces to be flexible so that we get the most out of the true datalayout.

@charleskawczynski charleskawczynski force-pushed the ck/specialize_column branch 2 times, most recently from 52d78ba to 6a8a2e9 Compare October 24, 2024 20:14
@Sbozzolo
Copy link
Member

I also would like to see this. Note that this will require also fixing all the postprocessing (that assumed that columns were actually boxes) and fixing this: CliMA/ClimaCore.jl#2032

charleskawczynski and others added 3 commits January 15, 2025 10:38
This accompanies changes to ClimaCore.
Add ClimaCore from parallel development branch.
Only run some column jobs on buildkite, skip others.
Don't take diagnostics.
Dev gb/bump for ClimaDiagnostics.
Moves the creation of the "orog" diagnostic to into the
`get_diagnostics` function. The "orog" diagnositc can't be
calulated on a purely vertical space, but it is part of the core
common diagnostics. It is possible to check the if the space is
1 dimensional inside `core_default_diagnostics`, but only when
output_writer is a NetCDFWriter. If a different output_writer is used,
no information about the space is passed into the `default_diagnostics`
funtion.
Horizontal tendencies are skipped when using a
purely vertical column space.

TODO: add tests, see if non_orographic_gravity_wave should still
be allowed with a purely vertical column, horizontal_integral,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants