-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try using purely vertical spaces for column configurations #3398
Draft
charleskawczynski
wants to merge
6
commits into
main
Choose a base branch
from
ck/specialize_column
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/specialize_column
branch
2 times, most recently
from
October 24, 2024 20:14
52d78ba
to
6a8a2e9
Compare
I also would like to see this. Note that this will require also fixing all the postprocessing (that assumed that columns were actually boxes) and fixing this: CliMA/ClimaCore.jl#2032 |
charleskawczynski
force-pushed
the
ck/specialize_column
branch
from
January 6, 2025 21:33
1bb3ff1
to
77bf8f7
Compare
5 tasks
This accompanies changes to ClimaCore.
Add ClimaCore from parallel development branch. Only run some column jobs on buildkite, skip others. Don't take diagnostics.
imreddyTeja
force-pushed
the
ck/specialize_column
branch
from
January 15, 2025 18:51
5d9c81a
to
2563f84
Compare
Dev gb/bump for ClimaDiagnostics. Moves the creation of the "orog" diagnostic to into the `get_diagnostics` function. The "orog" diagnositc can't be calulated on a purely vertical space, but it is part of the core common diagnostics. It is possible to check the if the space is 1 dimensional inside `core_default_diagnostics`, but only when output_writer is a NetCDFWriter. If a different output_writer is used, no information about the space is passed into the `default_diagnostics` funtion.
This reverts commit 2e501c3.
Horizontal tendencies are skipped when using a purely vertical column space. TODO: add tests, see if non_orographic_gravity_wave should still be allowed with a purely vertical column, horizontal_integral,
imreddyTeja
force-pushed
the
ck/specialize_column
branch
from
January 22, 2025 20:37
addca79
to
9432760
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at calibrations, I realized that we seem to always generate
VIJFH
datalayouts, even for column cases. Our CPU and GPU code paths for each datalayout is split so that we can optimize kernels specifically for those datalayouts. So, we should probably allow these spaces to be flexible so that we get the most out of the true datalayout.