Add override_precipitation_timescale option back in
#3509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nefrathenrici
force-pushed
the
ne/params
branch
from
d630056 to
01b17bb
Compare
|
Results for which job changed? Was it one that we had reproduceability tests for? |
I think it didn't show up in the reproducibility test as the job designed to catch this is too short to produce precipitation, so the PR didn't change the MSE of that job. There are some other jobs of which the results are changing, but we don't have reproducibility tests for them. |
nefrathenrici
force-pushed
the
ne/params
branch
from
01b17bb to
bdb0933
Compare
nefrathenrici
force-pushed
the
ne/params
branch
from
bdb0933 to
b2b851a
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
nefrathenrici
force-pushed
the
ne/params
branch
from
b2b851a to
6a23f66
Compare
nefrathenrici
force-pushed
the
ne/params
branch
from
6a23f66 to
0f107a6
Compare
nefrathenrici
force-pushed
the
ne/params
branch
from
0f107a6 to
5c6d620
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts part of #3481, which removed the
override_precipitation_timescaleconfig argument.This was not caught by our regression tests, but the the PR build shows changed plots.
This PR also adds a small unit test to ensure that this option is being set correctly.