Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: split our api and implementation into seperate modules #1566

Merged
merged 81 commits into from
Jan 17, 2025

Conversation

0utplay
Copy link
Member

@0utplay 0utplay commented Dec 28, 2024

Motivation

We want to ensure that our api and implementation are split.

Modification

Our API is mostly dependency less now and the implementation is located in the corresponding impl modules.

Result

API and implementation are split properly.

@0utplay 0utplay added v: 4.X This pull should be included in the 4.0 release in: node An issue/pull request releated to the node module code in: module An issue/pull request releated to one of the internal modules a: api An issue/pull request that is related to api changes. labels Dec 28, 2024
@0utplay 0utplay self-assigned this Dec 28, 2024
Copy link

github-actions bot commented Dec 28, 2024

Test Results

 48 files  ± 0   48 suites  ±0   1m 30s ⏱️ -17s
432 tests +12  432 ✅ +12  0 💤 ±0  0 ❌ ±0 
763 runs  +12  763 ✅ +12  0 💤 ±0  0 ❌ ±0 

Results for commit 28fdaff. ± Comparison against base commit 790ec42.

This pull request removes 398 and adds 410 tests. Note that renamed tests count towards both.
eu.cloudnetservice.common.column.ColumnTextFormatterTest ‑ testDataFormatting()
eu.cloudnetservice.common.column.RowedFormatterTest ‑ testRowBasedFormatting()
eu.cloudnetservice.common.concurrent.CompletedTaskTest ‑ testFutureCompletedNormally()
eu.cloudnetservice.common.concurrent.CountingTaskTest ‑ testCountingTask()
eu.cloudnetservice.common.concurrent.ListenableTaskTest ‑ testTaskRunAndReset()
eu.cloudnetservice.common.concurrent.ListenableTaskTest ‑ testTaskRunAndResetExceptionTerminatesInstantly()
eu.cloudnetservice.common.concurrent.TaskUtilTest ‑ testFinishedFuture()
eu.cloudnetservice.common.concurrent.TaskUtilTest ‑ testFutureCompletedNormally()
eu.cloudnetservice.common.concurrent.TaskUtilTest ‑ testFutureExceptionalCompletion()
eu.cloudnetservice.common.concurrent.TaskUtilTest ‑ testFutureTimeout()
…
eu.cloudnetservice.driver.base.JavaVersionTest ‑ testNextAndUnsupportedAreHidden()
eu.cloudnetservice.driver.base.JavaVersionTest ‑ testResolveFromClassVersion()
eu.cloudnetservice.driver.base.JavaVersionTest ‑ testResolveFromMajor()
eu.cloudnetservice.driver.base.JavaVersionTest ‑ testRuntimeVersion()
eu.cloudnetservice.driver.base.JavaVersionTest ‑ testVersionGuessing()
eu.cloudnetservice.driver.base.JavaVersionTest ‑ testVersionRangeChecking()
eu.cloudnetservice.driver.impl.document.DocumentPropertyTest ‑ [1] {}
eu.cloudnetservice.driver.impl.document.DocumentSerialisationTest ‑ [1] {}
eu.cloudnetservice.driver.impl.document.DocumentSerialisationTest ‑ [1] {}, PRETTY
eu.cloudnetservice.driver.impl.document.DocumentSerialisationTest ‑ [2] {"test":1234,"world":5.999,"boolean":false,"hello":"world"}, COMPACT
…

♻️ This comment has been updated with latest results.

@0utplay 0utplay requested a review from schucko1337 December 29, 2024 13:06
schucko1337
schucko1337 previously approved these changes Jan 4, 2025
@0utplay 0utplay merged commit 2613676 into nightly Jan 17, 2025
5 checks passed
@0utplay 0utplay deleted the feat/api-impl-split branch January 17, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: api An issue/pull request that is related to api changes. in: module An issue/pull request releated to one of the internal modules in: node An issue/pull request releated to the node module code v: 4.X This pull should be included in the 4.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants