-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: split our api and implementation into seperate modules #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0utplay
added
v: 4.X
This pull should be included in the 4.0 release
in: node
An issue/pull request releated to the node module code
in: module
An issue/pull request releated to one of the internal modules
a: api
An issue/pull request that is related to api changes.
labels
Dec 28, 2024
Test Results 48 files ± 0 48 suites ±0 1m 30s ⏱️ -17s Results for commit 28fdaff. ± Comparison against base commit 790ec42. This pull request removes 398 and adds 410 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
schucko1337
requested changes
Dec 29, 2024
.../impl/src/main/java/eu/cloudnetservice/driver/impl/module/DefaultModuleDependencyLoader.java
Outdated
Show resolved
Hide resolved
.../impl/src/main/java/eu/cloudnetservice/driver/impl/module/DefaultModuleDependencyLoader.java
Outdated
Show resolved
Hide resolved
...odb/api/src/main/java/eu/cloudnetservice/modules/mongodb/config/MongoDBConnectionConfig.java
Outdated
Show resolved
Hide resolved
...ql/impl/src/main/java/eu/cloudnetservice/modules/mysql/impl/CloudNetMySQLDatabaseModule.java
Outdated
Show resolved
Hide resolved
...tabase-mysql/impl/src/test/java/eu/cloudnetservice/modules/mysql/impl/MySQLDatabaseTest.java
Outdated
Show resolved
Hide resolved
node/impl/src/main/java/eu/cloudnetservice/node/impl/config/JsonConfiguration.java
Outdated
Show resolved
Hide resolved
1 task
schucko1337
previously approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a: api
An issue/pull request that is related to api changes.
in: module
An issue/pull request releated to one of the internal modules
in: node
An issue/pull request releated to the node module code
v: 4.X
This pull should be included in the 4.0 release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to ensure that our api and implementation are split.
Modification
Our API is mostly dependency less now and the implementation is located in the corresponding
impl
modules.Result
API and implementation are split properly.