Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sources priorities taken into account #11324

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Sources priorities taken into account #11324

wants to merge 6 commits into from
+107 −7

Conversation

rehsals
Copy link

@rehsals rehsals commented Apr 20, 2022

See: #8679

@rehsals rehsals mentioned this pull request Apr 20, 2022
Open
1 task
@rehsals rehsals force-pushed the bugfix/sources-priority-fix branch from b17ac63 to 498cbf6 Compare April 20, 2022 12:40
@rehsals rehsals force-pushed the bugfix/sources-priority-fix branch from 498cbf6 to f2f4c8a Compare April 21, 2022 08:39
@rehsals rehsals marked this pull request as ready for review May 16, 2022 07:30
@dnkoutso dnkoutso added this to the 1.12.0 milestone Jun 23, 2022
@dnkoutso
Copy link
Contributor

Hi there can you add a CHANGELOG entry? thanks!

@rehsals
Copy link
Author

rehsals commented Jun 23, 2022

H! Sure, I'll add CHANGELOG entry

@rehsals
Copy link
Author

rehsals commented Jun 30, 2022

Hey @dnkoutso
I've added a CHANGELOG entry. But we also need this CocoaPods/Molinillo#166 to be merged.
Otherwise this fix won't be entirely correct.
How is it advisable to proceed here?

ghost
ghost reviewed Aug 26, 2022
View reviewed changes
CHANGELOG.md Outdated
@@ -30,6 +30,10 @@ To install release candidates run `[sudo] gem install cocoapods --pre`

##### Bug Fixes

* Sources priority in Podfile warks as stated in documentation.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: We've got a typo -- 'warks' should be 'works'.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Fixed

@dnkoutso dnkoutso modified the milestones: 1.12.0, 1.12.1 Feb 27, 2023
@dnkoutso dnkoutso modified the milestones: 1.12.1, 1.13.0 Apr 18, 2023
@dnkoutso dnkoutso modified the milestones: 1.13.0, 1.14.0 Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rehsals @dnkoutso