Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the bundler with clean, it seems to work fine without on later releases of bundler #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove the bundler with clean, it seems to work fine without on later releases of bundler #9

wants to merge 1 commit into from

Conversation

orta
Copy link
Member

@orta orta commented Dec 1, 2016

I couldn't use any rake commands because of errors like:

screen shot 2016-12-01 at 09 53 00

Removing the with_clean_env fixed it 👍

@segiddins
Copy link
Member

I'm afraid this might actually break things, as running bundle install once BUNDLE_GEMFILE is set won't pick up the gemfile in the subdirectory

segiddins
segiddins reviewed Dec 1, 2016
View reviewed changes
Rakefile
Bundler.with_clean_env do
puts `bundle install`
end
puts `bundle install`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be sh "bundle install"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hah - yeah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@segiddins segiddins segiddins left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orta @segiddins