Add search functionality #117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jpadilla Here's some basic search functionality.
|
added 17 commits
January 19, 2020 18:03
Signed-off-by: Froilan Irizarry <[email protected]>
Signed-off-by: Froilan Irizarry <[email protected]>
Signed-off-by: Froilan Irizarry <[email protected]>
Signed-off-by: Froilan Irizarry <[email protected]>
Signed-off-by: Froilan Irizarry <[email protected]>
Signed-off-by: Froilan Irizarry <[email protected]>
Signed-off-by: Froilan Irizarry <[email protected]>
- Added query field to the FilterForm Signed-off-by: Froilan Irizarry <[email protected]>
- Search now uses tag filter - Search now filters by the final search vector Signed-off-by: Froilan Irizarry <[email protected]>
Signed-off-by: Froilan Irizarry <[email protected]>
- Search view now uses tag filter and text search - cache_key now uses query as part of its key - removed redundant filters Signed-off-by: Froilan Irizarry <[email protected]>
Signed-off-by: Froilan Irizarry <[email protected]>
Signed-off-by: Froilan Irizarry <[email protected]>
Signed-off-by: Froilan Irizarry <[email protected]>
- Tags dropdown does search on change. Form submit button needs to be pressed. - Input field takes free text and is not required to search with tag filter. Signed-off-by: Froilan Irizarry <[email protected]>
- Tags dropdown does search on change. Form submit button needs to be pressed. - Input field takes free text and is not required to search with tag filter. Signed-off-by: Froilan Irizarry <[email protected]>
Signed-off-by: Froilan Irizarry <[email protected]>
|
Hola a todos. Perdon que esto tomo tanto tiempo. La funcionalidad de busqueda esta lista para probar. Lo que queda por hacer es refinar el UI. Para esto necesito un poco de ayuda. Esta es la pagina principal.
Estoy seguro que @gcollazo no le va gustar esto 😝 pero no se que hacer para arreglar esto con los styles existentes. Esta es la pagina con los resultados de busqueda
Cambios
|
Closed
|
This Pull Request is being marked as Stale because it has 30 days without any interaction. CC: @gcollazo |
|
UPS sorry no vi los screenshots de arriba 🤷♂️ |
|
Creo que todavía necesita cariño la parte del UI, but up to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in here
Adding full text search functionality to the app using PostgreSQL as our search backend.
What's the plan
municipality,title,tags, andcontentfields from our model.Closes #105