-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Python 3.8 and Django 1.11 #104
base: master
Are you sure you want to change the base?
Conversation
Hi Russ, Just a few comments here. First, it looks like the sitemap is being updated to point to your forked repo. I'm not sure that's what really want. Also, I'm not sure that we want to keep the existing froide code base and update it to support django 4.x or 5.x. The newer froide code has features like support for 2FA which is really nice and seems to work fine when Brian and I tested it on a dev uipa instance. Finally, have you a chance to test your changes against the existing uipa code base when running in a container? Maybe we can meet or discuss this somewhere to avoid duplicating efforts? |
The raw version of the
Yes, 2FA is good. It could be back-ported.
No, I haven't tested my changes in a container. Assuming that the future production deployment will be in containers, then that is a must-do.
Sure, I'd be happy to meet in person to discuss thing. DM me on Slack. |
I'm looking at the diffs, in particular this one and the strings in the diff appear to point to your repo. Please correct me if I'm wrong but I don't think those are being changed behind the scenes.
Sure, we can backport that. But I don't think it's feasible to backport features and security fixes from 7+ years of development on the froide codebase. At the very least, I think we'd need to go through changes and identify and bring over security fixes and that's likely to be a lot of work.
Brian and I have been working with and testing a new uipa website using containers and I see using containers to deploy simply because it makes life easier and gives us assurances that we're testing what the production site will be. |
Yes, you are correct. Will push an update for that. Thanks! |
This is a step toward running UIPA.org on supported versions of Python and Django without upgrading to a newer upstream version of Froide.
Changes:
NOTE: This is for the branch that is currently running UIPA.org.