Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded patternlab-node to v3 #44

Closed
wants to merge 2 commits into from
Closed

Conversation

ganny26
Copy link

@ganny26 ganny26 commented Oct 10, 2019

#42
I have followed official wiki from patternlab and made changes

https://github.com/pattern-lab/patternlab-node/wiki/Upgrading

Major changes:

  • patternlab-config.json file has major changes
  • Package names changed to scoped packages from now

@CLAassistant
Copy link

CLAassistant commented Oct 10, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@mbulfair mbulfair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Make sure the project opens
  • runs with 0 errors
  • a pattern can be added
  • files are copied to output on build

Also the build is failing for some missing files, and bad configuration.

package.json Show resolved Hide resolved
@ganny26
Copy link
Author

ganny26 commented Oct 11, 2019

Hi @mbulfair

  • Removed old patternlab-node
  • Also upgraded styleguidekit-assets-default and styleguidekit-mustache-default to new scoped packages
  • Post install script not required as mentioned in upgrading wiki

Now project building successfully

mbulfair
mbulfair previously approved these changes Oct 11, 2019
@mbulfair mbulfair dismissed their stale review October 11, 2019 12:59

testing locally and it doesn't build

@mbulfair
Copy link
Member

@ganny26

This warning appears:

Configuration key [debug] inside patternlab-config.json was found. As of Pattern Lab Node Core 3.0.0 this key is replaced with a new key, [logLevel]. This is a string with possible values ['debug', 'info', 'warning', 'error', 'quiet'].
Turning on 'info', 'warning', and 'error' levels by default, unless [logLevel] is present. If that is the case, [debug] has no effect.

as well as ,

(node:10561) UnhandledPromiseRejectionWarning: TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type undefined

@mbulfair mbulfair closed this Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants