feat: add option to include parse tokens in serialize #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-evans
force-pushed
the
include-parse-tokens-option
branch
from
7d21f5b to
e784fe2
Compare
tim-evans
force-pushed
the
include-parse-tokens-option
branch
from
e784fe2 to
1567783
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option to include parse tokens in serialization to Peritext, which is helpful in cases where someone wants to view source of a document in a case like viewing the HTML tokens of the document, while allowing for text highlighting. The feature is also useful for debugging cases where you may want to see if some data is getting truncated unintentionally.
A feature like this was used for the hytradboi talk I did on wikitext parsing. In trying to ensure that everything is working well on
mainwith the quite extensive changes in the last year, I'm trying to update that project to see if there are any issues with the new format :)Regardless of this feature, the changes to the
sortTokensfunction may improve performance in some cases and be more legible for other developers