Introduce SSZ support in Builder API #8994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolfyone
reviewed
Jan 15, 2025
| public Response(final T payload) { | ||
| this.payload = payload; | ||
| this.errorMessage = null; | ||
| public static <T> Response<T> fromPayloadReceivedAsJson(final T payload) { |
There was a problem hiding this comment.
maybe better just as fromJsonPayload
rolfyone
reviewed
Jan 15, 2025
| public Response(final T payload, final String errorMessage) { | ||
| this.payload = payload; | ||
| this.errorMessage = errorMessage; | ||
| public static <T> Response<T> fromPayloadReceivedAsSsz(final T payload) { |
There was a problem hiding this comment.
but technically the payload has been already decoded at this stage. It indicates how you received the payload rather than the format of the payload passed here. I have mixed feelings
rolfyone
reviewed
Jan 15, 2025
...gration-test/java/tech/pegasys/teku/ethereum/executionclient/rest/RestBuilderClientTest.java
Show resolved
Hide resolved
...onclient/src/main/java/tech/pegasys/teku/ethereum/executionclient/rest/OkHttpRestClient.java
Outdated
Show resolved
Hide resolved
we also need to test that we correctly "revert" back to JSON if the getHeader response changes to JSON (e.g. builder software gets downgraded or some config changes). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands the Builder Rest client to handle ssz in
getHeaderandpostPayloadmethods.The general idea is that in
getHeaderwe signal viaAcceptheader that we supportsszandjson(withsszpreference).If we receive the header in
ssz, we remember this and on the upcomingpostPayloadwe will post the signed blinded block insszformat.possible additional things:
isUnsupportedMediaTypeErrorinResponseto try to fallback to json in postPayload (maybe not really important)ssztoo. At immediately fallback toJSON(and remain inJSON) if the first call fails for whatever reason (independently by 415, which could be not implemented on server side). If the first call succeed we could keep sendingssz(not falling back on generic error). This assumes that the relay doesn't change in the mean time from one supportingsszto another not supportingssz. But this would be out of spec RN.Fixed Issue(s)
fixes #8746
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog