Reuse earliest blob slot #9031
Merged
Reuse earliest blob slot #9031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
…ng streaming from 0 all the time. Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
…arliestFinalizedBlock Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
…g creating streaming from 0 all the time." This reverts commit 0ca062a Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
tbenr
reviewed
Jan 28, 2025
storage/src/main/java/tech/pegasys/teku/storage/server/kvstore/KvStoreDatabase.java
Outdated
Show resolved
Hide resolved
| @@ -436,7 +449,7 @@ private UInt64 pruneToBlock( | |||
| } | |||
|
|
|||
| try (final Stream<SignedBeaconBlock> stream = | |||
| dao.streamFinalizedBlocks(UInt64.ZERO, checkpointInitialSlot)) { | |||
| dao.streamFinalizedBlocks(earliestFinalizedBlockSlot, checkpointInitialSlot)) { | |||
There was a problem hiding this comment.
these two rounds of streamFinalizedBlocks are a bit of a mystery to me.
why we need the second? and if we really need it why we cant simply stream keys (we just need slots here and the slot in the key is always block.getSlot()).
There was a problem hiding this comment.
I haven't looked into this optimization tbh, sound fair but I think I ran into issues when I first implemented this with 1 stream only
tbenr
reviewed
Jan 28, 2025
teku/src/main/java/tech/pegasys/teku/services/ServiceController.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
# Conflicts: # storage/src/main/java/tech/pegasys/teku/storage/server/kvstore/KvStoreDatabase.java
Signed-off-by: Gabriel Fukushima <[email protected]>
tbenr
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Based on top of ##9029
This uses similar approach of the earliest block available. Reuse the variable value when present otherwise keep the current behaviour of creating a stream from 0.
This reduces the time that it takes for the blob pruner to run from 60 secs to ~1-2 secs on rocksdb.
{"@timestamp":"2025-01-28T08:52:00,212","level":"DEBUG","thread":"storagePrunerAsyncRunner-async-1","class":"BlobSidecarPruner","message":"Pruning blobs up to slot 3381555, limit 12","throwable":""} {"@timestamp":"2025-01-28T08:52:01,736","level":"INFO","thread":"validator-async-1","class":"teku-validator-log","message":"Validator *** Published attestation Count: 1, Slot: 3512660, Root: f70a2b57992861ea63f576d7d0cc5bf891d2d2c475cac54ae42e61d0b8ca71d5","throwable":""} {"@timestamp":"2025-01-28T08:52:01,991","level":"DEBUG","thread":"storagePrunerAsyncRunner-async-1","class":"KvStoreDatabase","message":"Pruned 12 BlobSidecars","throwable":""} {"@timestamp":"2025-01-28T08:52:01,991","level":"DEBUG","thread":"storagePrunerAsyncRunner-async-1","class":"BlobSidecarPruner","message":"Blobs pruning finished in 1779 ms. Limit reached: true","throwable":""}Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog