Streamline Stargate/gRPC querier interfaces #2093
Conversation
| // RejectStargateQuerier is a querier that rejects all stargate queries. | ||
| // | ||
| // Use AcceptListStargateQuerier instead to create a list of accepted query types. | ||
| func RejectStargateQuerier(ctx sdk.Context, request *wasmvmtypes.StargateQuery) ([]byte, error) { |
There was a problem hiding this comment.
I guess this is breaking since it changes the signature of a public function.
There was a problem hiding this comment.
Yes, that's breaking. I would assume that most people don't use the RejectStargateQuerier directly, since it's the default anyways, but not sure.
There was a problem hiding this comment.
Github only finds copies, no usage: https://github.com/search?q=RejectStargateQuerier&type=code
So probably a good change to include in 0.55
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2093 +/- ##
==========================================
- Coverage 42.99% 42.99% -0.01%
==========================================
Files 85 85
Lines 11601 11600 -1
==========================================
- Hits 4988 4987 -1
- Misses 6166 6167 +1
+ Partials 447 446 -1
|
| } | ||
|
|
||
| var _ stargateQuerierFn = RejectStargateQuerier // just a type check |
|
Thanks for the reviews. Feel free to merge whenever you consider it useful for 0.55. |
This PR aims to improve readbility of the Stargate/gRPC querier interfaces and implementations. It helped me reason about what chains need to do to override defaults. Hope it helps someone.