We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The current component uses a type prop to define both the color and the behavior (hover color, underline) of the link.
type
This is quite confusing and constrains customization. So we should think of a new api that would allow behavior and color to be set independently.
The text was updated successfully, but these errors were encountered:
My proposition:
Split into multiple props:
color
hoverColor
decoration
hoverDecoration
Then, instead of linkTypes constants we have presets, like:
linkPresets = { FEATURED: { color: colors.INDIGO_MILK_CAP, hoverColor: 'inherit', decoration: 'none', hoverDecoration: 'underline' }, . . . }
So, we use it like:
<Link href="#" {...linkPresets.FEATURED}> Hello </Link>
Sorry, something went wrong.
No branches or pull requests
The current component uses a
type
prop to define both the color and the behavior (hover color, underline) of the link.This is quite confusing and constrains customization. So we should think of a new api that would allow behavior and color to be set independently.
The text was updated successfully, but these errors were encountered: