Link - Allow any CSS color for type prop
#488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcferreira
approved these changes
Aug 14, 2018
fgameiro
reviewed
Aug 14, 2018
| https://scene.zeplin.io/project/595a9cd3b401bf1876faab27/screen/59ee42dab95cec4ea9ed4e48 | ||
| https://scene.zeplin.io/project/595a9cd3b401bf1876faab27/screen/59ee42dac5418ce9dc27ffa2 | ||
| https://scene.zeplin.io/project/595a9cd3b401bf1876faab27/screen/59ee42da064e270badd9be38 | ||
|
|
fgameiro
approved these changes
Aug 14, 2018
fczuardi
reviewed
Aug 14, 2018
| <Link href="#" type="hotpink"> | ||
| Awesome Link | ||
| </Link> | ||
| )) |
There was a problem hiding this comment.
The featured link starts with the color, so having an undefined hover wont be an issue, will we need type=neutral behavior on liks with other colors? (no underline and a link color on hover)
There was a problem hiding this comment.
I created #489 for a refactor of this component
affects: @crave/farmblocks-link ISSUES CLOSED: #487
affects: @crave/farmblocks-link
affects: @crave/farmblocks-link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Issues
typeprop #487Code review checklist
Reviewer 1
Reviewer 2