Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transform PSQL2BigQuery into a CLI #9
Transform PSQL2BigQuery into a CLI #9
Changes from all commits
0b8a5f4
05263f7
a1109b8
168df9d
a2a877f
c2ace3c
4c72a9a
6440182
a127840
dd6e4ab
1c77cf9
6cab201
260125d
c070bfb
c448503
efdab62
7cf59ec
58b751e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's really good add a readme to project =D
What do you think about add a how-to run local to help developers contribute to the project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I added a new commit with a Contributing section.
Please tell me if there's anything I could add.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @joaodaher!
I'd be great to have more usage instructions and examples with the available params. Can you add that as well please?
It could also be in a different issue/PR, no problem. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A note that could be added to the instructions: --include and --exclude are mutually exclusive, so they can't be used together.
And here's the syntax for multiple tables (worth mentioning in the readme or command help):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a basic usage example for now.
We can improve later with a proper documentation of each parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @joaodaher, thanks!
Large diffs are not rendered by default.