-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local Hbar #60
Open
JoseMadriaga
wants to merge
7
commits into
CrawfordGroup:main
Choose a base branch
from
JoseMadriaga:local_hbar
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Local Hbar #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lothian
reviewed
Apr 3, 2023
Comment on lines
-13
to
+18
from .utils import helper_diis, cc_contract | ||
from .hamiltonian import Hamiltonian | ||
from .local import Local | ||
from .cctriples import t_tjl, t3c_ijk | ||
from .lccwfn import lccwfn | ||
from utils import helper_diis, cc_contract #helper_ldiis | ||
from hamiltonian import Hamiltonian | ||
from local import Local | ||
from cctriples import t_tjl, t3c_ijk | ||
from lccwfn import lccwfn | ||
from debug import Debug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you help me to understand what's happening here? Are you temporarily changing the interface to run the code directly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding local representation of Hbar to cchbar object that will be subsequently used for the lambda expressions
Todos
Notable points that this PR has either accomplished or will accomplish.
Notes
The local Hbar is tested against the simulation code. Further test can be made once the local lambda expressions are implemented.
Status