Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft of PNO Lambda CCD and CCSD #62

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

JoseMadriaga
Copy link
Contributor

@JoseMadriaga JoseMadriaga commented May 16, 2023

Description

Implementing the local representation of lambda at the CCD and CCSD level starting from the construction of the similarity-transformed Hamiltonian. This PR will allow calculations up to the lambda pseudo energy for any types of local correlation techniques.

Todos

Notable points that this PR has either accomplished or will accomplish.

  • add local hbar to cchbar object
  • add local lambda to cclambda object
  • modify simulation code test cases (test # 13,18,19,28) to run
  • add test files (# 35 - pno lambda ccd and # 36 - pno lambda ccd for various local correlation techniques)
  • add helical H2 chains geometries within molecules.py
  • need proper clean up and documentation

Notes

For the PNO lambda implementation:
https://github.com/JoseMadriaga/Notes

Status

  • Ready to go

@JoseMadriaga JoseMadriaga requested a review from lothian May 16, 2023 15:34
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2023

Codecov Report

Merging #62 (88f15e1) into main (69ecdbe) will increase coverage by 4.28%.
The diff coverage is 99.51%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

print("Hoooo norm = %20.15f" % np.linalg.norm(self.Hoooo))
print("Hvvvv norm = %20.15f" % np.linalg.norm(self.Hvvvv))

if ccwfn.local is None or ccwfn.filter is True:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I recall correctly, we discussed in our group meeting last week (5/16) that you were going to move the if-branches to the highest level and put all the Local calls for ccwfn, cchbar, and cclambda into a separate sub-directory. Is that still the plan? I don't remember if we decided you'd handle that after the current PR, so please remind me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is the plan after the current PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants