Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev a #29

Merged
merged 4 commits into from
Jan 27, 2025
Merged

Dev a #29

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
897316d
Testing
Crebs Jan 27, 2025
6dc9a0d
using updated urlwq
Crebs Jan 27, 2025
d089d03
Fixing Actor checks
Crebs Jan 27, 2025
c11f3a2
Merge branch 'dev' into dev-a
Crebs Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions .github/workflows/pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
uses: octokit/[email protected]
id: check_permission
with:
route: GET /repos/${{ github.repository }}/collaborators/${{ github.triggering_actor }}/permission
route: GET /repos/${{ github.repository }}/collaborators/${{ github.actor }}/permission
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Debug Permission Response
Expand All @@ -23,9 +23,9 @@ jobs:
- name: Validate Write Permission
run: |
permission=$(echo "${{ fromJson(steps.check_permissions.outputs.data).permission }}")
echo "User ${{ github.triggering_actor }} has permission: $permission"
echo "User ${{ github.actor }} has permissions: $permission"
if [[ "$permission" != "write" && "$permission" != "admin" ]]; then
echo "User ${{ github.triggering_actor }} does not have sufficient permission (write or admin) to proceed. Someone from the team needs to rerun this workflow AFTER it has been deemed safe."
echo "User ${{ github.actor }} does not have sufficient permissions (write or admin) to proceed."
exit 1
fi
- name: Checkout
Expand All @@ -52,7 +52,6 @@ jobs:
cd .github/DangerFiles
bundle update && bundle install
bundle exec danger --dangerfile=StaticAnalysis.rb --danger_id=StaticAnalysis

test-orchestrator:
runs-on: macos-15
outputs:
Expand All @@ -62,7 +61,7 @@ jobs:
uses: octokit/[email protected]
id: check_permission
with:
route: GET /repos/:org/:repo/collaborators/:user/permission
route: GET /repos/${{ github.repository }}/collaborators/${{ github.actor }}/permission
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Debug Permission Response
Expand All @@ -71,9 +70,9 @@ jobs:
- name: Validate Write Permission
run: |
permission=$(echo "${{ fromJson(steps.check_permissions.outputs.data).permission }}")
echo "User ${{ github.triggering_actor }} has permission: $permission"
echo "User ${{ github.actor }} has permissions: $permission"
if [[ "$permission" != "write" && "$permission" != "admin" ]]; then
echo "User ${{ github.triggering_actor }} does not have sufficient permission (write or admin) to proceed. Someone from the team needs to rerun this workflow AFTER it has been deemed safe."
echo "User ${{ github.actor }} does not have sufficient permissions (write or admin) to proceed."
exit 1
fi
- name: Checkout
Expand All @@ -91,7 +90,6 @@ jobs:
cd .github/DangerFiles
bundle update && bundle install
bundle exec danger --dangerfile=TestOrchestrator.rb

ios-pr:
needs: [test-orchestrator]
strategy:
Expand Down
Loading