GT-2303 Update logic to only download OneSky translations we ship #3444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om the other translation phrases
frett
force-pushed
the
GT-2303-OneSky-translation-download-update
branch
from
fd53df7 to
3ad435a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3444 +/- ##
========================================
Coverage 36.78% 36.78%
========================================
Files 446 446
Lines 10897 10897
Branches 2458 2458
========================================
Hits 4009 4009
Misses 6179 6179
Partials 709 709 ☔ View full report in Codecov by Sentry. |
gyasistory
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a request to maintain all translations for language names and next/prev buttons, but still filter out other translations.
This PR accomplishes this by leveraging a new
downloadLanguagesconfiguration parameter. I have submitted the change upstream, but until it is addressed there we will use a submodule to pull the change in to our project locally.