fix & improve steam auth on window

.mise.toml

@@ -1,5 +1,5 @@
 [tools]
-node = "latest"
+node = "22"
 
 [env]
 _.file = '.env.local'

package.json

@@ -49,6 +49,7 @@
     "@electron-toolkit/utils": "3.0.0",
     "@floating-ui/vue": "1.1.5",
     "@jitl/quickjs-wasmfile-release-sync": "0.31.0",
+    "@lydell/node-pty": "1.0.3",
     "@pipelab/core": "1.3.3",
     "@primevue/themes": "4.1.1",
     "@sentry/electron": "5.4.0",

src/shared/libs/plugin-core/utils.ts

@@ -1,4 +1,5 @@
 import { Options, Subprocess } from 'execa'
+import { IPty, type IPtyForkOptions, type IWindowsPtyForkOptions } from '@lydell/node-pty'
 
 export const runWithLiveLogs = async (
   command: string,
@@ -67,3 +68,39 @@ export const runWithLiveLogs = async (
     })
   })
 }
+
+export const runWithLiveLogsPTY = async (
+  command: string,
+  args: string[],
+  ptyOptions: IPtyForkOptions | IWindowsPtyForkOptions,
+  log: typeof console.log,
+  hooks?: {
+    onStdout?: (data: string, subprocess: IPty) => void
+    onStderr?: (data: string, subprocess: IPty) => void
+    onExit?: (code: number) => void
+  }
+): Promise<void> => {
+  const { spawn } = await import('@lydell/node-pty')
+  return new Promise((resolve, reject) => {
+    log('runWithLiveLogsPTY', command, args, ptyOptions)
+    log('command: ', command, args.join(' '))
+
+    const subprocess = spawn(command, args, ptyOptions)
+
+    subprocess.onData((data) => {
+      log(data.toString())
+      hooks?.onStdout?.(data.toString(), subprocess)
+    })
+
+    subprocess.onExit(({ exitCode, signal }) => {
+      log('exit', exitCode)
+      hooks?.onExit?.(exitCode)
+
+      if (exitCode === 0) {
+        return resolve()
+      } else {
+        return reject(new Error(`Command exited with non-zero exitCode: ${exitCode}`))
+      }
+    })
+  })
+}

src/shared/libs/plugin-steam/upload-to-steam.ts

@@ -86,8 +86,6 @@ export const uploadToSteamRunner = createActionRunner<typeof uploadToSteam>(
     const { join, dirname } = await import('path')
     const { platform } = await import('os')
     const { chmod, mkdir, writeFile } = await import('fs/promises')
-    // for esm
-    const { execa } = await import('execa')
 
     log('uploading to steam')
     const { folder, appId, sdk, depotId, username, description } = inputs
@@ -193,10 +191,10 @@ export const uploadToSteamRunner = createActionRunner<typeof uploadToSteam>(
       username
     })
 
-    console.log('isAuthenticated', isAuthenticated)
+    log('isAuthenticated', isAuthenticated)
 
     if (isAuthenticated.success === false) {
-      console.log('OPEN STEAM AUTH')
+      log('OPEN STEAM AUTH terminal')
       await openExternalTerminal(steamcmdPath, ['+login', username, '+quit'])
       const isAuthenticatedNow = await checkSteamAuth({
         context: {
@@ -222,7 +220,7 @@ export const uploadToSteamRunner = createActionRunner<typeof uploadToSteam>(
         steamcmdPath,
         ['+login', username, '+run_app_build', scriptPath, '+quit'],
         {},
-        log,
+        log
       )
     } catch (e) {
       if (e instanceof Error) {

src/shared/libs/plugin-steam/utils.ts

@@ -1,4 +1,4 @@
-import { runWithLiveLogs } from '../plugin-core'
+import { runWithLiveLogsPTY } from '../plugin-core'
 
 export type Options = {
   steamcmdPath: string
@@ -13,7 +13,7 @@ export const checkSteamAuth = async (options: Options) => {
   let error: 'LOGGED_OUT' | 'UNKNOWN' | undefined = undefined
 
   try {
-    await runWithLiveLogs(
+    await runWithLiveLogsPTY(
       options.steamcmdPath,
       ['+login', options.username, '+quit'],
       {},