Tasks contain property that tells the boefjerunner what network it is supposed to run on. #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Made it so that newly created tasks (made from an IPAddress OOI) contain an attribute that explains what network the task should be run on.
Issue link
Closes minvws#3222
Demo
Task not being ran because only boefje runners which check for the network: "internal-cynalytics" (which is currently not being active) has not picked it up.
QA notes
(Note that a new environment variable has been made called "network_scopes")
Try creating a new IPAddress with network "internet" and observe that it runs successfully. And after that create another IPAddress with a new self-made network and observe that wont be ran.
When you run the boefje container with your new network name included in the environment variable then the task should be ran.
Code Checklist
.env
changes files if required and changed the.env-dist
accordingly.Checklist for code reviewers:
Checklist for QA:
make reset
.feature
orhotfix
works as intended.What works:
What doesn't work:
Bug or feature?: