Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final Pass - User Facing Spanish Review #1633

Closed
lomky opened this issue Mar 3, 2019 · 14 comments
Closed

Final Pass - User Facing Spanish Review #1633

lomky opened this issue Mar 3, 2019 · 14 comments

Comments

@lomky
Copy link
Member

lomky commented Mar 3, 2019

This ticket is to capture the last needed Spanish translations for the Case Manager facing sections. Admin & Data manager sections are not required for this review.

  • What are we trying to do?

Browse around on the Spanish Review branch and look for English. Look at the regular text, any helper text (the "?"s), error messages, drop down selections. Try clicking and editing things. Sort things. Edit the call list. Try to break things!

Do not worry about the user entered text entered in fields. Values in notes, the patient name itself, other contact relationship, etc are not what we're looking for here. If you're uncertain though, just go ahead and add a comment of it!

Screen shot, or carefully describe in a comment here, the English.

Also look out for any errors related to translations.

  • What feature or behavior is this required for?

User facing Spanish release!

  • How could we solve this issue? (Not knowing is okay!)

Lotsa eyes.

@lomky
Copy link
Member Author

lomky commented Mar 3, 2019

Fixed.

"Forgot your password?". Would also be nice to have a language swap button on this screen.

screenshot from 2019-03-03 10-55-23

@lomky
Copy link
Member Author

lomky commented Mar 3, 2019

Fixed. We don't use this alert, so it's just ""

Alert upon login: translation missing: es.devise.sessions.user.signed_in

screenshot from 2019-03-03 10-56-39

@lomky
Copy link
Member Author

lomky commented Mar 3, 2019

done @colinxfleming #1641

Confirmation box for deleting a call: "Are you sure you want to remove this call from the call log?", "Cancel", "OK".

screenshot from 2019-03-03 11-03-15

(Unrelated, this is also an ugly box so we should theme it)

@colinxfleming
Copy link
Member

colinxfleming commented Mar 3, 2019

Done

From a fresh seed, logging a call for Other Contact:

image

@colinxfleming
Copy link
Member

colinxfleming commented Mar 3, 2019

Done @colinxfleming #1642

Most Recent Note in the note expander on the patient dashboard:

image

@colinxfleming
Copy link
Member

colinxfleming commented Mar 3, 2019

Ported to #1643 by @colinxfleming

This is bizarre, but on the patient dashboard locale seems to reset to english in table content partials after a manual control-r reload. We might just file this as a bug and move on but wanted to log it.

image

Steps to recreate:

  • Log in
  • Switch to spanish
  • Control-R to reload the page

@colinxfleming
Copy link
Member

colinxfleming commented Mar 3, 2019

P orting to an issue - @colinxfleming - #1639

Another weird bug -- Status seems to lag one way or the other in the patient edit view if you click back and forth. Here's an example of the spanish Resolved Without DCAF on the english page:
image

@colinxfleming
Copy link
Member

colinxfleming commented Mar 3, 2019

Done @colinxfleming #1640

If you update a field in the patient dashboard (top thing), it doesn't Respect The Localization when it reloads the weeks along calculations:

image

To recreate:

  • Go to a patient edit page
  • Set appointment date to be sometime in the future

@colinxfleming
Copy link
Member

colinxfleming commented Mar 3, 2019

Porting this to an issue @colinxfleming - #1638

I don't think we should worry about this for this round, but we should figure out what to do about the changelog field names:

image

@colinxfleming
Copy link
Member

colinxfleming commented Mar 3, 2019

Done @colinxfleming #1637

Need to set locale in the clinic finder search:

image

@colinxfleming
Copy link
Member

colinxfleming commented Mar 3, 2019

Fixed. We don't use this alert so it's just ""

On logout, a missing translation:

image

@lomky
Copy link
Member Author

lomky commented Mar 3, 2019

Fixed

Reset password and all else in the file app/views/devise/shared/_links.html.erb

screenshot from 2019-03-03 15-26-06

@lomky
Copy link
Member Author

lomky commented Mar 3, 2019

Fixed.

Missing translation:

screenshot from 2019-03-03 15-39-50

To recreate:
Hit forgot password
Hit me password reset intructions

@lomky
Copy link
Member Author

lomky commented Mar 3, 2019

For later, we should standardize our Devise wording either into separate files, or included in the base locale file, but not both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants