Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NONCE NONCE NONCE (dances to techNOOOOO) #1096

Closed
wants to merge 1 commit into from
Closed

NONCE NONCE NONCE (dances to techNOOOOO) #1096

wants to merge 1 commit into from

Conversation

DarthHater
Copy link
Member

I rule and have completed some work on Case Manager that's ready for review!

Trying out a nonce using SecureRandom (http://daniel.fone.net.nz/blog/2014/12/07/generating-unique-random-tokens/)

This pull request makes the following changes:

  • Minor changes to application_controller.rb (with large implications)

It relates to the following issue #s:

@DarthHater
Copy link
Member Author

@colinxfleming so this kinda switches to nonces, although there's a few issues thus far that I've noticed:

  • It only applies to inline scripts on self, not every script (guessing this was intentional)
  • it needs to be applied to the inline script (which I can't find?)

@DarthHater DarthHater mentioned this pull request Jun 5, 2017
Merged
@DarthHater
Copy link
Member Author

Closing in favor of going with something like #1102 , experimental PR is this one (Yoda would say, or someone like me with bad English)

@DarthHater DarthHater closed this Jun 7, 2017
@DarthHater DarthHater deleted the NonceToBeSaidAboutIt branch June 7, 2017 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DarthHater