Add referred_by to config #1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 20, 2018 14:30
colinxfleming
previously requested changes
Oct 21, 2018
Co-Authored-By: tingaloo <[email protected]>
|
Shouldn't this also have a UI change where the user can set this in the admin ("Configuration Management") section? |
…ent into enhancement/1500
|
I spruced this up some. @lomky or @DarthHater a review at yr leisure pls! |
lomky
approved these changes
Dec 17, 2018
There was a problem hiding this comment.
Looks awesome! 🎊
As I was poking around in the GUI, I found myself wanting some visual clarity in the Current Options list for hard coded base options vs custom options. There's also some weirdness in the languages display. Ultimately I think those are nice-to-have and probably things to put to a general 'cleanup the configs page' issue. Thoughts?
|
The UI thing is an A++ flag. rep'd that in #1559 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rule and have completed some work on Case Manager that's ready for review!
Vacate the code.
This pull request makes the following changes:
It relates to the following issue #s: