Combine stacks of coins, make combine work in adventure mode #1227
+33
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o the now wrong inventory due to item removals)
Ozzatron
suggested changes
Jul 16, 2024
can you synthesize this with sent keystrokes? |
myk002
reviewed
Jul 19, 2024
Added docs for `combine item`
The thing is, when you press the "examine" button, the inventory is still technically 'open'. But I can't send the 'inventory' keystroke from the screen that's examining the item, meaning I'd have to create a hook to wait on the user to come back to the inventory to refresh it. Alternatively, I would re-generate the inventory myself from code in the background but I'm sure to miss something. Therefore the safest route is to simply close the inventory interface and tell the user that happened. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow combine to work in adventure mode and also combine stacks of coins
Note that it's safer to use the (z) -> Items tab to combine stacks currently, as doing so from the (i)nventory will not update the interface to reflect the change until you quit out of the inventory and come back. Currently, this is resolved by closing the inventory interface, prompting the player to bring it up manually themselves.