Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a save reminder to notifications panel #1373

Merged
merged 8 commits into from
Jan 16, 2025

Conversation

realSquidCoder
Copy link
Contributor

After 15 irl mins, a notification pops up, telling you how many mins it has been since last save. Clicking this notification opens a Yes/No prompt that asks if you wish to quicksave. This can be turned off same as all the other notifications.

@realSquidCoder
Copy link
Contributor Author

merge this after DFHack/dfhack#5203

Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs changelog entry, but otherwise looks good!

internal/notify/notifications.lua Outdated Show resolved Hide resolved
internal/notify/notifications.lua Outdated Show resolved Hide resolved
internal/notify/notifications.lua Outdated Show resolved Hide resolved
internal/notify/notifications.lua Outdated Show resolved Hide resolved
internal/notify/notifications.lua Outdated Show resolved Hide resolved
internal/notify/notifications.lua Outdated Show resolved Hide resolved
internal/notify/notifications.lua Outdated Show resolved Hide resolved
@realSquidCoder
Copy link
Contributor Author

needs changelog entry, but otherwise looks good!

where do i find the changelog for this and how would i word it?

@myk002
Copy link
Member

myk002 commented Jan 16, 2025

where do i find the changelog for this and how would i word it?

The scripts changelog is changelog.txt in the scripts repo. unlike in stonesense, it is not in the docs directory. You can search for previous gui/notify lines for examples (e.g. line 178)

@myk002 myk002 merged commit a28dd7c into DFHack:master Jan 16, 2025
1 check passed
@realSquidCoder realSquidCoder deleted the squid-save-reminder branch January 16, 2025 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants