-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add show
to assign-preferences
script
#1377
Open
TolMera
wants to merge
8
commits into
DFHack:master
Choose a base branch
from
TolMera:assign-preferences/createNewMethodShow
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat: Add show
to assign-preferences
script
#1377
TolMera
wants to merge
8
commits into
DFHack:master
from
TolMera:assign-preferences/createNewMethodShow
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature returns the list of preferences for a selected dwarf. This script may be useful if: * a user wants to view a quick list of likes for a dwarf * a user wants to view the list of likes after updating a dwarfs likes * Other scripts may find this helpful, as this functionality is not otherwise exposed via dfhack
…ub.com/TolMera/dfhack-scripts into assign-preferences/createNewMethodShow
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
myk002
reviewed
Jan 19, 2025
Co-authored-by: Myk <[email protected]>
…ub.com/TolMera/dfhack-scripts into assign-preferences/createNewMethodShow
For notes see: DFHack#1377 (comment)
myk002
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! we're in code freeze for the release tomorrow, but I'll merge it soon after we tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature returns the list of preferences for a selected dwarf.
This script may be useful if: