Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganized most of the important graphics for Stonesense #157

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

realSquidCoder
Copy link
Contributor

This will make adding new art easier. There are more changes needed but this is already a metric ton of changes.

@realSquidCoder realSquidCoder marked this pull request as ready for review January 20, 2025 22:12
@realSquidCoder
Copy link
Contributor Author

I basically sorted it into the build menu categories and then alphabetically

Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what to think about this reorganization. It puts non-fort-specific resources in a fort-specific hierarchy, leading to cross-directory references and duplication of artwork files. I'm just not sure it makes sense.

@ab9rf
Copy link
Member

ab9rf commented Jan 20, 2025

I'm not getting the motivation here, and I can't say I'm thrilled with using sibling and parent folder references

@realSquidCoder
Copy link
Contributor Author

The ultimate goal is to split up the sprite sheets to be more specific and make it easier for new contributors. There is a duplicate image i know of (the doorandfloodgates image) but that is going to be split int to a "doors and hatches" image and the other one will be just floodgates. stuff like that is why i want this

@realSquidCoder
Copy link
Contributor Author

its also easier to find whats missing (for me anyways)

@myk002
Copy link
Member

myk002 commented Jan 20, 2025

Remember that for DF, the organization of the fort mode build menu is arbitrary and disjoint from the actual object definitions and relationships.

@realSquidCoder
Copy link
Contributor Author

fair. tbh i just wanted some sorting as a proof of concept. if theres a better way, im listening

Split images up and fixed XML to follow suit.

Affected:
- cages-restraints
- doors-hatches
- furniture
- machines-fluids
@realSquidCoder
Copy link
Contributor Author

realSquidCoder commented Jan 21, 2025

i'll need to move the contents in the images later, this is more just to show what im going to do

@myk002
Copy link
Member

myk002 commented Jan 28, 2025

I think the consensus was that there should be few/a single sprite sheet and a flat hierarchy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants