Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure proper browser closure #18404

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Conversation

TonyRL
Copy link
Collaborator

@TonyRL TonyRL commented Feb 19, 2025

Involved Issue / 该 PR 相关 Issue

Close #

Example for the Proposed Route(s) / 路由地址示例

/test/1

New RSS Route Checklist / 新 RSS 路由检查表

  • New Route / 新的路由
  • Anti-bot or rate limit / 反爬/频率限制
    • If yes, do your code reflect this sign? / 如果有, 是否有对应的措施?
  • Date and time / 日期和时间
    • Parsed / 可以解析
    • Correct time zone / 时区正确
  • New package added / 添加了新的包
  • Puppeteer

Note / 说明

@github-actions github-actions bot added core enhancement Route Auto: Route Test Complete Auto route test has finished on given PR labels Feb 19, 2025
Copy link
Contributor

Successfully generated as following:

http://localhost:1200/test/1 - Success ✔️
<?xml version="1.0" encoding="UTF-8"?>
<rss xmlns:atom="http://www.w3.org/2005/Atom" version="2.0">
  <channel>
    <title>Test 1</title>
    <link>https://github.com/DIYgod/RSSHub</link>
    <atom:link href="http://localhost:1200/test/1" rel="self" type="application/rss+xml"></atom:link>
    <description>A test route for RSSHub - Powered by RSSHub</description>
    <generator>RSSHub</generator>
    <webMaster>[email protected] (RSSHub)</webMaster>
    <language>en</language>
    <lastBuildDate>Wed, 19 Feb 2025 20:00:48 GMT</lastBuildDate>
    <ttl>5</ttl>
    <item>
      <title>Title1</title>
      <description>Description1</description>
      <link>https://github.com/DIYgod/RSSHub/issues/1</link>
      <guid isPermaLink="false">https://github.com/DIYgod/RSSHub/issues/1</guid>
      <pubDate>Mon, 31 Dec 2018 15:59:50 GMT</pubDate>
      <author>DIYgod1</author>
    </item>
    <item>
      <title>Title2</title>
      <description>Description2</description>
      <link>https://github.com/DIYgod/RSSHub/issues/2</link>
      <guid isPermaLink="false">https://github.com/DIYgod/RSSHub/issues/2</guid>
      <pubDate>Mon, 31 Dec 2018 15:59:40 GMT</pubDate>
      <author>DIYgod2</author>
    </item>
    <item>
      <title>Title3</title>
      <description>Description3</description>
      <link>https://github.com/DIYgod/RSSHub/issues/3</link>
      <guid isPermaLink="false">https://github.com/DIYgod/RSSHub/issues/3</guid>
      <pubDate>Mon, 31 Dec 2018 15:59:30 GMT</pubDate>
      <author>DIYgod3</author>
    </item>
    <item>
      <title>Title4</title>
      <description>Description4</description>
      <link>https://github.com/DIYgod/RSSHub/issues/4</link>
      <guid isPermaLink="false">https://github.com/DIYgod/RSSHub/issues/4</guid>
      <pubDate>Mon, 31 Dec 2018 15:59:20 GMT</pubDate>
      <author>DIYgod4</author>
    </item>
    <item>
      <title>Title5</title>
      <description>Description5</description>
      <link>https://github.com/DIYgod/RSSHub/issues/5</link>
      <guid isPermaLink="false">https://github.com/DIYgod/RSSHub/issues/5</guid>
      <pubDate>Mon, 31 Dec 2018 15:59:10 GMT</pubDate>
      <author>DIYgod5</author>
    </item>
  </channel>
</rss>

@TonyRL TonyRL merged commit 674b322 into DIYgod:master Feb 19, 2025
31 checks passed
@TonyRL TonyRL deleted the fix/puppeteer branch February 19, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto: Route Test Complete Auto route test has finished on given PR core enhancement Route
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant