Skip to content

Commit

Permalink
Fix doc/code mismatch on FINISH case 9.4
Browse files Browse the repository at this point in the history
The doc expects UnexpectedRequest, before KEY_EXCHANGE.
But the code only send VC without ALGORITHM.

However, if VCA is used, then the error is SessionRequired.
That also makes sense, because without KEY_EXCHANGE there is no session.

As such, just fix the doc to match the code.

Signed-off-by: Jiewen Yao <[email protected]>
  • Loading branch information
jyao1 committed Oct 26, 2023
1 parent 2ea0e8f commit 09d3254
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions doc/9.FinishRsp.md
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ Assertion 9.3.*.

### Case 9.4

Description: SPDM responder shall return ERROR(UnexpectedRequest), if it receives a FINISH before KEY_EXCHANGE.
Description: SPDM responder shall return ERROR(UnexpectedRequest), if it receives a FINISH before NEGOTIATE_ALGORITHMS.

SPDM Version: 1.1+

Expand All @@ -141,8 +141,6 @@ TestSetup:
4. Requester -> GET_CAPABILITIES {SPDMVersion=NegotiatedVersion, ...}
5. CAPABILITIES <- Responder
6. If Flags.KEY_EX_CAP == 0, then skip this case.
7. Requester -> NEGOTIATE_ALGORITHMS {SPDMVersion=NegotiatedVersion, ...}
8. ALGORITHMS <- Responder

TestTeardown: None

Expand Down

0 comments on commit 09d3254

Please sign in to comment.