-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix chunk_seq_no wrap issue. #2952
base: main
Are you sure you want to change the base?
Conversation
3c503f8
to
2f8dd0c
Compare
spdm_context->connection_info.capability.data_transfer_size, | ||
spdm_context->local_context.capability.sender_data_transfer_size); | ||
|
||
max_chunk_data_transfer_size = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should also consult max_spdm_msg_size.
min_data_transfer_size = LIBSPDM_MIN( | ||
spdm_context->connection_info.capability.data_transfer_size, | ||
spdm_context->local_context.capability.sender_data_transfer_size); | ||
|
||
/* Fail if exceed max chunks */ | ||
max_chunk_data_transfer_size = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should also consult max_spdm_msg_size.
Fix DMTF#2875 Signed-off-by: Aaron Li <[email protected]>
Fix DMTF#2875 Signed-off-by: Aaron Li <[email protected]>
Fix DMTF#2875 Signed-off-by: Aaron Li <[email protected]>
Fix DMTF#2875 Signed-off-by: Aaron Li <[email protected]>
The newly added test case for chunk get in requester will cost ~90s if print to console or ~10s if print to file. |
When the Requester receives the first |
In Spec line 812:
Which means the Responder could send chunk messages with |
Are you saying that even if the check passes then the |
Got it, it make sense to add additional check to improve the performance. |
Fix #2875