Feat: Update to core v1.3.4 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henry-wallace-phys
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description:
Move inline with Core tag v1.3.4
Ben J has already tested the atmospheric event rates and found perfect agreement (https://dunescience.slack.com/archives/C081KNBQ37E/p1737135928943809?thread_ts=1736521441.861849&cid=C081KNBQ37E).
Get matching event rates as the v1.2.0_alpha branch:
[EventRates.cpp][info] Event rate for FHC_numu : 7977.54
[EventRates.cpp][info] Event rate for FHC_nue : 1716.61
[EventRates.cpp][info] Event rate for RHC_numu : 4217.30
[EventRates.cpp][info] Event rate for RHC_nue : 448.08
Changes or fixes:
Update CMake structure to be more inline with T2K's approach, remove signal variable from MC struct, include more complete warnings
Examples: