Feature/dbarrow257/osc prob dune old core #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n DUNE MaCh3 and the new core code
…/OscProb_DUNE_OldCore
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dbarrow257
requested changes
Feb 11, 2025
configs/Variations_Atmospherics.yaml
Outdated
| #T2K-like best-fit | ||
| #OscillationParameters: [0.307, 0.528, 0.0218, 7.53e-5, 2.509e-3, -1.601, 25] | ||
|
|
||
| Variations: |
There was a problem hiding this comment.
Could you move this to it's own node? I.e. see the Projections node at the bottom of this config?
src/Variations.cpp
Outdated
| for (int iPar=0;iPar<nPars;iPar++) { | ||
| std::string ParName = CovObj->GetParName(iPar); | ||
|
|
||
| for (auto const ¶m : FitManager->raw()["General"]["Variations"]) { |
There was a problem hiding this comment.
And the associated change here for moving the Variations to it's own node
| @@ -0,0 +1,130 @@ | |||
| #include <iostream> | |||
There was a problem hiding this comment.
Could you add a few lines about the structure of the Variations YAML node, and expected structure?
Also can you add a TODO about considering merging this with the SigmaVariations app?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description:
Addition of apps for 2D variations of parameters. Also included example .yaml file to use the app Variations2D