Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kleykamp groo fix #124

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Kleykamp groo fix #124

merged 2 commits into from
Jul 15, 2024

Conversation

jdkio
Copy link
Contributor

@jdkio jdkio commented Jul 12, 2024

gRoo is the edep sim "pass through" tree DetSimPassThru/gRooTracker which holds the genie information. For neutrino events, it's always there. But particle guns are missing this info. That's why it's important to check that it exists before trying to read from it. One check was missing and this PR adds it to fix issue #123. It also removes the cout for slices

I don't have the particle gun datasets so I wasn't able to test on those, but I imagine it'll work. Someone should please try

Copy link
Member

@LiamOS LiamOS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise this looks sane and what I'd've done.

@AsaNehm Should I merge this or would you like to run a test on a particle gun file first?

Copy link
Contributor

@AsaNehm AsaNehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No segmentation violation with particle gun files anymore. So seems to work

@LiamOS LiamOS merged commit 77fd1c1 into main Jul 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants