Add nersc-style pileup #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… remove pass-by-reference for TG4Event into TMS_Event
…oat effects when saving hit times
…ent. But it's fixed by merging inside. As long as optical effects are applied first, we can remerge a second time later and fix the bug for now
LiamOS
reviewed
Aug 16, 2024
| @@ -330,7 +359,7 @@ TMS_Event::TMS_Event(TMS_Event &event, int slice) : TMS_Hits(event.GetHits(slice | |||
|
|
|||
|
|
|||
| nTrueTrajectories = -999; | |||
| VertexIdOfMostEnergyInEvent = -999; | |||
| VertexIdOfMostEnergyInEvent = -9991; | |||
There was a problem hiding this comment.
Is this number intentional? May be better to have just 9s, even though that's still not completely ideal.
Edit: Nevermind, I get it. Don't love it but if it works it's not stupid.
LiamOS
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old pileup is also supported. Takes care to make sure all branches are filled sensibly. The primary lepton/neutrino are always from the vertex that contributed the most visible energy for that timeslice. That's right in 99% of cases. Can also look at full particle list if needed. There are a bunch of branches which are likely overfull, like the fact that it saves all primary and "interesting" particles per spill. But root compression takes care of it. See talk at TMS studies meeting