Add isTestnet flag from config service (safe-global#1093)

Adds a new `isTestnet` flag to `Chain` as per [the config service integration](safe-global/safe-config-service#1036).
Dadudida-com · Jan 31, 2024 · 194c500 · 194c500
1 parent 11bb359
commit 194c500
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 0 deletions.
diff --git a/src/domain/chains/entities/__tests__/chain.builder.ts b/src/domain/chains/entities/__tests__/chain.builder.ts
@@ -15,6 +15,7 @@ export function chainBuilder(): IBuilder<Chain> {
     .with('chainName', faker.company.name())
     .with('description', faker.word.words())
     .with('l2', faker.datatype.boolean())
+    .with('isTestnet', faker.datatype.boolean())
     .with('shortName', faker.company.name())
     .with('rpcUri', rpcUriBuilder().build())
     .with('safeAppsRpcUri', rpcUriBuilder().build())

diff --git a/src/domain/chains/entities/chain.entity.ts b/src/domain/chains/entities/chain.entity.ts
@@ -11,6 +11,8 @@ export interface Chain {
   chainName: string;
   description: string;
   l2: boolean;
+  // TODO: Make required when deemed stable on config service
+  isTestnet?: boolean;
   shortName: string;
   rpcUri: RpcUri;
   safeAppsRpcUri: RpcUri;

diff --git a/src/domain/chains/entities/schemas/chain.schema.ts b/src/domain/chains/entities/schemas/chain.schema.ts
@@ -121,6 +121,8 @@ export const chainSchema: JSONSchemaType<Chain> = {
     chainName: { type: 'string' },
     description: { type: 'string' },
     l2: { type: 'boolean' },
+    // TODO: Make required when deemed stable on config service
+    isTestnet: { type: 'boolean', nullable: true },
     shortName: { type: 'string' },
     rpcUri: { $ref: 'rpc-uri.json' },
     safeAppsRpcUri: { $ref: 'rpc-uri.json' },
@@ -144,6 +146,7 @@ export const chainSchema: JSONSchemaType<Chain> = {
     'chainName',
     'description',
     'l2',
+    // isTestnet,
     'shortName',
     'rpcUri',
     'safeAppsRpcUri',

diff --git a/src/routes/chains/chains.controller.spec.ts b/src/routes/chains/chains.controller.spec.ts
@@ -95,6 +95,7 @@ describe('Chains Controller (Unit)', () => {
               chainName: chainsResponse.results[0].chainName,
               description: chainsResponse.results[0].description,
               l2: chainsResponse.results[0].l2,
+              isTestnet: chainsResponse.results[0].isTestnet,
               shortName: chainsResponse.results[0].shortName,
               rpcUri: chainsResponse.results[0].rpcUri,
               safeAppsRpcUri: chainsResponse.results[0].safeAppsRpcUri,
@@ -114,6 +115,7 @@ describe('Chains Controller (Unit)', () => {
               chainName: chainsResponse.results[1].chainName,
               description: chainsResponse.results[1].description,
               l2: chainsResponse.results[1].l2,
+              isTestnet: chainsResponse.results[1].isTestnet,
               shortName: chainsResponse.results[1].shortName,
               rpcUri: chainsResponse.results[1].rpcUri,
               safeAppsRpcUri: chainsResponse.results[1].safeAppsRpcUri,
@@ -206,6 +208,7 @@ describe('Chains Controller (Unit)', () => {
         chainName: chainDomain.chainName,
         description: chainDomain.description,
         l2: chainDomain.l2,
+        isTestnet: chainDomain.isTestnet,
         nativeCurrency: chainDomain.nativeCurrency,
         transactionService: chainDomain.transactionService,
         blockExplorerUriTemplate: chainDomain.blockExplorerUriTemplate,

diff --git a/src/routes/chains/chains.service.ts b/src/routes/chains/chains.service.ts
@@ -54,6 +54,7 @@ export class ChainsService {
           chain.shortName,
           chain.theme,
           chain.ensRegistryAddress,
+          chain.isTestnet,
         ),
     );
 
@@ -84,6 +85,7 @@ export class ChainsService {
       result.shortName,
       result.theme,
       result.ensRegistryAddress,
+      result.isTestnet,
     );
   }
 

diff --git a/src/routes/chains/entities/chain.entity.ts b/src/routes/chains/entities/chain.entity.ts
@@ -43,6 +43,9 @@ export class Chain {
   description: string;
   @ApiProperty()
   l2: boolean;
+  // TODO: Make required when implemented on config service and deemed stable
+  @ApiPropertyOptional()
+  isTestnet?: boolean;
   @ApiProperty()
   nativeCurrency: ApiNativeCurrency;
   @ApiProperty()
@@ -96,11 +99,14 @@ export class Chain {
     shortName: string,
     theme: Theme,
     ensRegistryAddress: string | null,
+    // TODO: Make required when deemed stable on config service
+    isTestnet?: boolean,
   ) {
     this.chainId = chainId;
     this.chainName = chainName;
     this.description = description;
     this.l2 = l2;
+    this.isTestnet = isTestnet;
     this.nativeCurrency = nativeCurrency;
     this.transactionService = transactionService;
     this.blockExplorerUriTemplate = blockExplorerUriTemplate;