Remove floating promises (safe-global#1095)

This enables a linting warning for floating promises and solves the few warnings that were found after enabling it.

---

* Catch and log cache clearing failures after deletion

* Remove floating promises

.eslintrc.js

@@ -24,5 +24,6 @@ module.exports = {
       { assertionStyle: 'as' },
     ],
     '@typescript-eslint/no-explicit-any': 'error',
+    '@typescript-eslint/no-floating-promises': 'warn',
   },
 };

src/datasources/cache/cache.module.ts

@@ -21,7 +21,7 @@ async function redisClientFactory(
   client.on('error', (err) =>
     loggingService.error(`Redis client error: ${err}`),
   );
-  client.connect();
+  await client.connect();
   return client;
 }
 

src/datasources/cache/redis.cache.service.spec.ts

@@ -103,7 +103,7 @@ describe('RedisCacheService', () => {
       faker.string.sample(),
     );
     const value = fakeJson();
-    redisClient.hSet(cacheDir.key, cacheDir.field, value);
+    await redisClient.hSet(cacheDir.key, cacheDir.field, value);
 
     const storedValue = await redisCacheService.get(cacheDir);
 
@@ -117,7 +117,7 @@ describe('RedisCacheService', () => {
       faker.string.sample(),
     );
     const value = fakeJson();
-    redisClient.hSet(cacheDir.key, cacheDir.field, value);
+    await redisClient.hSet(cacheDir.key, cacheDir.field, value);
 
     await redisCacheService.deleteByKey(cacheDir.key);
 

src/main.ts

@@ -13,4 +13,4 @@ async function bootstrap(): Promise<void> {
   await app.listen(applicationPort);
 }
 
-bootstrap();
+void bootstrap();

src/routes/alerts/alerts.controller.ts

@@ -22,6 +22,6 @@ export class AlertsController {
     @Body(AlertValidationPipe)
     alertPayload: Alert,
   ): Promise<void> {
-    this.alertsService.onAlert(alertPayload);
+    await this.alertsService.onAlert(alertPayload);
   }
 }