Fix snug x<y
#830
Fix snug x<y
#830
Conversation
| WAssignmentOp | ||
| __ AssignmentOp | ||
| _ OperatorAssignmentOp | ||
| _? OperatorAssignmentOp |
There was a problem hiding this comment.
I think this change allows something like x[1]xor= true or x[1]min= x[0] which doesn't look great... but I guess it's OK, looking at the new test case. Certainly can't mean anything else.
| @@ -2991,23 +2990,23 @@ AssignmentOp | |||
| # This is separate from AssignmentOp because it only works in certain contexts | |||
| # (in particular, not at the beginning of a line). | |||
| OperatorAssignmentOp | |||
| Xor "=" &Whitespace _? -> | |||
| Xor "=" _? -> | |||
There was a problem hiding this comment.
This allows x xor=y which... is probably fine, just pointing it out.
| # (e.g. whitespace) after "<". This does forbid 1<2 or x<y. | ||
| /<(?!\p{ID_Start}|[_$])/ -> | ||
| return "<" | ||
| "<" |
There was a problem hiding this comment.
Kind of surprised this works! But must be an old way of avoiding ambiguity.
There was a problem hiding this comment.
It originally caused some trouble with class X extends A<B> but switching to enforcing ExtendsTarget as a LeftHandSideExpression fixes it by requiring parens around expressions.
| --- | ||
| x<y | ||
| """ | ||
|
|
There was a problem hiding this comment.
Perhaps should also add x<y>z from #824?
Oops, already merged — I'll add it.
No description provided.