Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tweaking production/development output #577

Merged
merged 9 commits into from
Dec 19, 2024

Conversation

DannyBen
Copy link
Owner

@DannyBen DannyBen commented Dec 18, 2024

cc #576, #575

This PR adds these options to the settings:

# allowed values: always, never, production, development
enable_header_comment: always
enable_bash3_bouncer: always
enable_view_markers: development
enable_inspect_args: development
enable_deps_array: always
enable_env_var_names_array: always

This allows the user to define which of these features is rendered in which environment.

@DannyBen DannyBen added this to the 1.2.7 milestone Dec 18, 2024
@DannyBen
Copy link
Owner Author

DannyBen commented Dec 18, 2024

@EmilyGraceSeville7cf - made some additions to settings.json schema, if you can review.

@EmilyGraceSeville7cf
Copy link
Collaborator

@DannyBen, I will review it in several hours.😀 I have checked linked issues and I can say for sure that I love this idea of having such settings added.

@DannyBen
Copy link
Owner Author

DannyBen commented Dec 18, 2024

@EmilyGraceSeville7cf - note that I have just made the settings.json schema generate from YAML (in support/schemas folder), like we did with schemas/bashly.yml. It renders with 2 spaces instead of 4, this is why when viewing the diff without "Hide whitespaces", it looks like it was all changed.

Copy link
Collaborator

@EmilyGraceSeville7cf EmilyGraceSeville7cf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@DannyBen DannyBen merged commit 16568b7 into master Dec 19, 2024
8 checks passed
@DannyBen DannyBen deleted the add/settings-tweaks branch December 19, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants