percentage ckipped task fails if spec_path doesn't exist

DataDog · Oct 15, 2024 · 0013500 · 0013500
1 parent 514cbe0
commit 0013500
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/lib/datadog/ci/test_optimisation/skippable_percentage/base.rb b/lib/datadog/ci/test_optimisation/skippable_percentage/base.rb
@@ -13,6 +13,7 @@ def initialize(verbose: false, spec_path: "spec")
             @failed = false
 
             log("Spec path: #{@spec_path}")
+            error!("Spec path is not a directory: #{@spec_path}") if !File.directory?(@spec_path)
           end
 
           def call

diff --git a/lib/datadog/ci/test_optimisation/skippable_percentage/calculator.rb b/lib/datadog/ci/test_optimisation/skippable_percentage/calculator.rb
@@ -20,6 +20,8 @@ def initialize(rspec_cli_options: [], verbose: false, spec_path: "spec")
           end
 
           def call
+            return 0.0 if @failed
+
             require_rspec!
             configure_datadog
 

diff --git a/lib/datadog/ci/test_optimisation/skippable_percentage/estimator.rb b/lib/datadog/ci/test_optimisation/skippable_percentage/estimator.rb
@@ -24,6 +24,8 @@ def initialize(verbose: false, spec_path: "spec")
           end
 
           def call
+            return 0.0 if @failed
+
             require "datadog/ci"
 
             Datadog.configure do |c|