fix browser name and version tags for cuprite

DataDog · Jan 21, 2025 · 3499c33 · 3499c33
1 parent b44f9a9
commit 3499c33
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/lib/datadog/ci/contrib/cuprite/driver.rb b/lib/datadog/ci/contrib/cuprite/driver.rb
@@ -44,8 +44,8 @@ def visit(url)
               # set the tags specific to the browser test
               active_test.set_tag(CI::Ext::Test::TAG_BROWSER_DRIVER, "cuprite")
               active_test.set_tag(CI::Ext::Test::TAG_BROWSER_DRIVER_VERSION, datadog_integration.version)
-              active_test.set_tag(CI::Ext::Test::TAG_BROWSER_NAME, browser.options.browser_name)
-              active_test.set_tag(CI::Ext::Test::TAG_BROWSER_VERSION, browser.version)
+              active_test.set_tag(CI::Ext::Test::TAG_BROWSER_NAME, browser.options.browser_name || "chrome")
+              active_test.set_tag(CI::Ext::Test::TAG_BROWSER_VERSION, browser.version.product)
 
               result
             end

diff --git a/vendor/rbs/cuprite/0/driver.rbs b/vendor/rbs/cuprite/0/driver.rbs
@@ -8,7 +8,7 @@ module Ferrum
 end
 
 class Ferrum::Browser
-  def version: () -> String
+  def version: () -> Ferrum::Browser::VersionInfo
 
   def options: () -> Ferrum::Browser::Options
 end
@@ -17,6 +17,10 @@ class Ferrum::Browser::Options
   def browser_name: () -> String
 end
 
+class Ferrum::Browser::VersionInfo
+  def product: () -> String
+end
+
 module Capybara::Cuprite::Driver
   def visit: (String url) -> untyped