exploring using RSpec scoped_id metadata as parameters metadata to ma…

…ke sure examples have unique fingerprint
DataDog · Jan 12, 2024 · 76f2a35 · 76f2a35
1 parent eb7066a
commit 76f2a35
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/lib/datadog/ci/contrib/rspec/example.rb b/lib/datadog/ci/contrib/rspec/example.rb
@@ -37,6 +37,8 @@ def run(example_group_instance, reporter)
                 },
                 service: configuration[:service_name]
               ) do |test_span|
+                test_span.set_parameters({}, {"scoped_id" => metadata[:scoped_id]})
+
                 result = super
 
                 case execution_result.status

diff --git a/lib/datadog/ci/span.rb b/lib/datadog/ci/span.rb
@@ -139,7 +139,7 @@ def set_default_tags
       # @param [Hash] metadata optional metadata
       # @return [void]
       def set_parameters(arguments, metadata = {})
-        return if arguments.nil? || arguments.empty?
+        return if arguments.nil?
 
         set_tag(
           Ext::Test::TAG_PARAMETERS,

diff --git a/spec/datadog/ci/contrib/rspec/instrumentation_spec.rb b/spec/datadog/ci/contrib/rspec/instrumentation_spec.rb
@@ -375,8 +375,12 @@ def rspec_session_run(with_failed_test: false, with_shared_test: false)
         shared_test_spans = test_spans.filter { |test_span| test_span.name == "SomeTest shared examples adds 1 and 1" }
         expect(shared_test_spans).to have(2).items
 
-        shared_test_spans.each do |shared_test_span|
+        shared_test_spans.each_with_index do |shared_test_span, index|
           expect(shared_test_span.get_tag(Datadog::CI::Ext::Test::TAG_SUITE)).to eq(spec.file_path)
+
+          expect(shared_test_span.get_tag(Datadog::CI::Ext::Test::TAG_PARAMETERS)).to eq(
+            "{\"arguments\":{},\"metadata\":{\"scoped_id\":\"1:#{2 + index}:1\"}}"
+          )
         end
 
         test_spans.each do |test_span|