rename set_internal_tracing_context! to set_trace_origin as this is w…

…hat it does
DataDog · Nov 8, 2023 · 8b5636e · 8b5636e
1 parent b61b2c7
commit 8b5636e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lib/datadog/ci/recorder.rb b/lib/datadog/ci/recorder.rb
@@ -36,7 +36,7 @@ def trace_test(test_name, service_name: nil, operation_name: "test", tags: {}, &
 
         if block
           Datadog::Tracing.trace(operation_name, **span_options) do |tracer_span, trace|
-            set_internal_tracing_context!(trace, tracer_span)
+            set_trace_origin(trace)
 
             test = build_test(tracer_span, tags)
 
@@ -48,7 +48,7 @@ def trace_test(test_name, service_name: nil, operation_name: "test", tags: {}, &
           tracer_span = Datadog::Tracing.trace(operation_name, **span_options)
           trace = Datadog::Tracing.active_trace
 
-          set_internal_tracing_context!(trace, tracer_span)
+          set_trace_origin(trace)
 
           test = build_test(tracer_span, tags)
           @local_context.activate_test!(test)
@@ -89,8 +89,8 @@ def active_span
 
       private
 
-      def set_internal_tracing_context!(trace, span)
-        # Sets trace's origin to ciapp-test
+      # Sets trace's origin to ciapp-test
+      def set_trace_origin(trace)
         trace.origin = Ext::Test::CONTEXT_ORIGIN if trace
       end
 

diff --git a/sig/datadog/ci/recorder.rbs b/sig/datadog/ci/recorder.rbs
@@ -18,7 +18,7 @@ module Datadog
 
       def create_datadog_span: (String span_name, ?span_options: Hash[untyped, untyped], ?tags: Hash[untyped, untyped]) ?{ (Datadog::CI::Span span) -> untyped } -> untyped
 
-      def set_internal_tracing_context!: (Datadog::Tracing::TraceOperation trace, Datadog::Tracing::SpanOperation span) -> untyped
+      def set_trace_origin: (Datadog::Tracing::TraceOperation trace) -> untyped
 
       private
-Original file line number
+Diff line change
@@ Expand Up / @@ -18,7 +18,7 @@ module Datadog @@
           def create_datadog_span: (String span_name, ?span_options: Hash[untyped, untyped], ?tags: Hash[untyped, untyped]) ?{ (Datadog::CI::Span span) -> untyped } -> untyped
-          def set_internal_tracing_context!: (Datadog::Tracing::TraceOperation trace, Datadog::Tracing::SpanOperation span) -> untyped
+          def set_trace_origin: (Datadog::Tracing::TraceOperation trace) -> untyped
           private
@@ Expand Down @@